Xlights to FPP integration for opendmx type

[AAH]

While faultfinding for a customer I came across an issue. When doing a controller upload of an opendmx output on 1 of my rpi-mfc the FPP instance (8.4 from memory) it uploads the config for the dmx output as opendmx and FPP says that it can't configure/open that protocol type. A quick search through the 2 github repositories show that the 2 (same) protocols have different naming conventions which as a result breaks stuff.

In xlights the protocol type is opendmx.
const static std::vector<std::vector<std::string>> __equivalentSerial = {
    { "dmx", "dmx512" },
    { "dmx-open", "opendmx" },

In FPP the protocol required is DMX-Open
if (config.isMember("type")) {
std::string type = config["type"].asString();
if (type == "DMX-Open") {

My rpi-mfc and rpi-28D+ are affected and I suspect that the Falcon Pi-Cap and any other FPP based board with a dmx output would be also.
LogDebug(VB_CHANNELOUT, "Treating device as DMX-Open compatible\n");
m_dongleType = DMX_DVC_OPEN;
} else if (type == "DMX-Pro") {
LogDebug(VB_CHANNELOUT, "Treating device as DMX-Pro compatible\n");
m_dongleType = DMX_DVC_PRO;

[darylc]

Hi Alan,

I'd suggest logging a bug against xlights if you think it's misconfiguring fpp - You can do that from https://github.com/xLightsSequencer/xLights/issues