Color Order

[K-State Fan]

I switched from a K8-PB to the new version of the same controller. Nothing wrong with the old ones just wanted to try the electronic fuses. 

When i got every thing together the color of my 5 arches on that controller were wrong everything else was correct. I changed the order in xLights to GBR and uploaded to controller  they had been BRG and everything is working fine. I was not expecting this when I was doing my test and looked for other problems prior to changing the color order.

[Poporacer]

I changed the order in xLights to GBR and uploaded to controller  they had been BRG and everything is working fine.

There are 2 places to set the color order in xLights and you should only set it in one place. Is it possible it is set in both places?

I was not expecting this when I was doing my test

How were you testing? Xlights Test, FPP Display Test, FPP Port test, Sequence? The different tests can sometimes produce different results. 

[K-State Fan]

I changed the order in xLights to GBR and uploaded to controller  they had been BRG and everything is working fine.

There are 2 places to set the color order in xLights and you should only set it in one place. Is it possible it is set in both places?

I was not expecting this when I was doing my test

How were you testing? Xlights Test, FPP Display Test, FPP Port test, Sequence? The different tests can sometimes produce different results.

I set the order in the controller settings and use the standard RGB for all my string properties.

I use a sequence of 30 seconds all red, 30 seconds of all green, 30 seconds of all blue then 30 seconds of all white for my testing.

I was just surprised that i had to change the color order with the new controller.

[JonD]

It seems there was an update a while back where one was out of order for years and no one noticed it.  Could it be that you are running a newer FPP software version than the older K8?   
 9e17aab9 - Poporacer  - 2023-09-05 15:01:31 -0600 - fix color order to be consistent with convention.

[K-State Fan]

I am using 7.3.5 this year and would have been on what ever was current last year at Thanksgiving


Sent from my iPhone using Tapatalk

[Poporacer]

It seems there was an update a while back where one was out of order for years and no one noticed it.  Could it be that you are running a newer FPP software version than the older K8?   
 9e17aab9 - Poporacer  - 2023-09-05 15:01:31 -0600 - fix color order to be consistent with convention.

LOL, that commit was for the testing so that it would fall into a logical order of RGB, not RBG...But you are on the right track. I fixed an actual bug in the pixel strings code.
https://github.com/FalconChristmas/fpp/commit/5252f1d84c9c369afa4fc6d926f7237ed1f829ac

I was just surprised that i had to change the color order with the new controller.

There was bug in FPP since its creation that the color order was incorrect for GBR and BRG strings and was fixed . I found it odd that no-one had reported this bug, but chalked it up to that no one was using strings with that color order. But I guess people just changed the color order until it worked. Hopefully that explains it....

[JonD]

LOL, that commit was for the testing so that it would fall into a logical order of RGB, not RBG...But you are on the right track. I fixed an actual bug in the pixel strings code.

I was thinking you wrote the patch, and was wondering why you wasn't taking credit for your hard work!

[Poporacer]

I was thinking you wrote the patch, and was wondering why you wasn't taking credit for your hard work!

To be honest, I forgot about it....but now it looks like my understanding of the code might have been flawed and I broke what wasn't broken...LOL

[JonD]

To be honest, I forgot about it....but now it looks like my understanding of the code might have been flawed and I broke what wasn't broken...LOL

I had to adjust some lights this fall as well, but in my case I knew exactly who to blame for it.   I suspect most don't know what the actual order is, just knew it was off and needed adjusted. 

[Poporacer]

@K-State Fan It looks like my "fix" was based on bad logic....Sorry. Just a FYI the color order will probably be reverted back in the release next year. Just so that you are aware....

[K-State Fan]

@K-State Fan It looks like my "fix" was based on bad logic....Sorry. Just a FYI the color order will probably be reverted back in the release next year. Just so that you are aware....

Nothing to be sorry about.

I need to make a note about it so I remember but I won't and will forget.

[JonD]

It looks like my "fix" was based on bad logic....Sorry.

Joking aside... my vote (which does not count) is leaving it in the correct color order.   If it was off before and you corrected it, that is a good thing.  Despite his questionable favorite college sports team, K-State was not having issues and was just wondering why there was a difference!   Okay maybe not all joking aside!

[Poporacer]

my vote (which does not count)

Neither do mine! LOL

If it was off before and you corrected it, that is a good thing.

The problem is that it really wasn't broke before and I misunderstood the logic....But I still don't understand why I felt it was broken in the first place to feel that I needed to dig in the code.   I don't go looking for code to fix, LOL

[K-State Fan]

It looks like my "fix" was based on bad logic....Sorry.

Joking aside... my vote (which does not count) is leaving it in the correct color order.  If it was off before and you corrected it, that is a good thing.  Despite his questionable favorite college sports team, K-State was not having issues and was just wondering why there was a difference!   Okay maybe not all joking aside!

I will ignore the team comment.

After I changed the color order I had no problems but it does complicate things if you have to have the color order different depending on what controller you have it hooked up to.

[JonD]

I will ignore the team comment.

You should!   Not sure if you picked up where I am from.  Iowa State and K-State are both in the Big 12.  I suppose K-State is just fine as long as they are not playing I-State.